Copy latest certificate on before build

[gwleuverink]

It turns out the cacert.pem file was only copied over during the serve command.
A build before at least running serve once was impossible due to the certificate not being present.

This PR adds a step to the build command to move the latest file over on every build.

[SRWieZ]

Isn't this handled by the JavaScript side ? Why does npm run dev do it and not npm run build ?

[PeteBishwhip]

Isn't this handled by the JavaScript side ? Why does npm run dev do it and not npm run build ?

It doesn't. It's our serve/dev command that copies it. (See php.js)

If you go to build without ever running native:dev/serve, the cacert will not be present and the build will fail.

Even if you do, if you don't run dev after updating php-bin, you would not copy the latest version of cacert.pem whilst building.

[SRWieZ]

Sorry, my question was: shouldn't we be consistent with the dev command?

I don't really like the current situation

"dev": "cross-env node php.js && electron-vite dev --watch",
"build": "electron-vite build",

The first step could be to move this PR to a Trait and use it in DevelopCommand and BuildCommand, and remove it from php.js.

Approved anyway 😉

[gwleuverink]

@SRWieZ you're right. This should be consistent across the board.

I think it's covered in Pete's follow-up PR

[simonhamp]

On the consistency issue: When we build, php.js is executed via electron-builder.js

I suspect the underlying reason for it failing was that the certificatePath variable wasn't being set on build, only on dev.