Skip errors when copying files during build #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to get a research task added to our Backlog to look into exactly how differently PHP sees A second thought I had was whether we should document somewhere about the storage directory just to reduce support queries on warnings around it? Lets see how this does in the wild. |
PeteBishwhip
approved these changes
Feb 28, 2025
gwleuverink
changed the title
SRWieZ
approved these changes
Feb 28, 2025
|
This is a good enough solution for now guys. I like it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue while building, caused by a linked storage directory.
This works as expected on mac, but failed on windows. Symlinks do not really exist there, thus the existing conditional clauses had some unexpected behaviour.
Using symlinks is discouraged as per the docs: https://nativephp.com/docs/desktop/1/digging-deeper/files#symlinks
Pete and I had a quick call, and decided to skip (but log) whenever a copy error occurred.
We might need to harden this further