Skip to content

fix: update nativephp/laravel version constraint #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented Feb 21, 2025

update nativephp/laravel version constraint to allow all versions during development

@PeteBishwhip PeteBishwhip requested a review from a team February 21, 2025 12:35
Copy link
Contributor

@gwleuverink gwleuverink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some people had trouble updating when this was set to *

This might require further investigation

@gwleuverink
Copy link
Contributor

Thanks! I ran into this too 🙏

@SRWieZ
Copy link
Member Author

SRWieZ commented Feb 21, 2025

Some people had trouble updating when this was set to *

This might require further investigation

I think it's because it was tagged with "*" or I am mistaken ?

@PeteBishwhip
Copy link
Member

I think its because composer doesn't see the 1.0.0 version as stable. It will still prefer the latest 0.x version over 1.0.0 until a stable tag is released.

@SRWieZ
Copy link
Member Author

SRWieZ commented Feb 21, 2025

So, what do you suggest? Should I merge it for now or not?

We can still revert if needed.

@PeteBishwhip
Copy link
Member

If it's working for you for now, I'm okay with a merge. As you said, its easy to revert.

You will however likely find that when you pull in nativephp/electron:^1.0@beta, you'll get a 0.x version of the laravel package.

@SRWieZ
Copy link
Member Author

SRWieZ commented Feb 21, 2025

Then it's okay to merge. In the dev phase, I mostly require nativephp/electron:dev-main or another branch.

@SRWieZ SRWieZ merged commit 346a442 into main Feb 21, 2025
11 of 22 checks passed
@SRWieZ SRWieZ deleted the composer-requirements branch February 21, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants