Add endpoint to resize MenuBar window #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkmdg
commented
Feb 7, 2025
|
I'm not clear why the yarn.lock was deleted... |
|
Me neither to be honest, I'll put it back! |
SRWieZ
requested changes
Feb 13, 2025
|
@SRWieZ the changes in the dist/index.js are just updates from the build command. Those changes comes from the existing codebase, but the built dist was lagging behind. This should probably be excluded entirely from the committed code, but I felt that was out of scope for my PR. |
|
Oh right, it's in the It shouldn't have happened, but that's on us. I'll try to improve this workflow. |
SRWieZ
approved these changes
Feb 13, 2025
PeteBishwhip
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new endpoint i
menuBar.tsto allow modification of MenuBar window after initialization, pretty much the same as for the WindowManager. This PR will be accompanied by NativePHP/laravel#490 containing an actual call in the MenuBarManager.