Do not silently drop system limit configurations - #3820
Open
lbschanno wants to merge 2 commits into
Open
Conversation
SystemLimitProvider.populateLimits() can silently drop SortableSystemLimit instances when there are two or more system configurations that result in the same matcher type, equal limits, equal values for countsAgainstUserLimit, and equal group override maps. Add a check to SortableSystemLimit.compareTo() to also check against matcher equality to ensure we do not drop matchers of the same type with different underlying patterns. Fixes #3818
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SystemLimitProvider.populateLimits() can silently drop SortableSystemLimit instances when there are two or more system configurations that result in the same matcher type, equal limits, equal values for countsAgainstUserLimit, and equal group override maps.
Add a check to SortableSystemLimit.compareTo() to also check against matcher equality to ensure we do not drop matchers of the same type with different underlying patterns.
Fixes #3818