Do not silently drop group limit overrides - #3819
Open
lbschanno wants to merge 1 commit into
Open
Conversation
QueryLogicGroupLimitProvider.createOverrides() can silently drop MatchableOverride instances when there are two or more mappings in the provided override map that resolve to equal Matcher types, and equal limits. Add a check to MatchableOverride.compareTo() to also check against matcher equality to ensure we do not drop matchers of the same type, but different underlying patterns. Add unit tests to verify fix. Fixes #3817
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueryLogicGroupLimitProvider.createOverrides() can silently drop MatchableOverride instances when there are two or more mappings in the provided override map that resolve to equal Matcher types, and equal limits.
Add a check to MatchableOverride.compareTo() to also check against matcher equality to ensure we do not drop matchers of the same type, but different underlying patterns. Add unit tests to verify fix.
Fixes #3817