Add replacement for datawave.ingest.util.ThreadUtil - #3816
Open
lbschanno wants to merge 2 commits into
Open
Conversation
Add the class datawave.concurrent.ThreadUtils to the common-utils module. This class is intended to be a replacement for datawave.ingest.util.ThreadUtil, placed in a more commonly accessible location. The following changes have also been made: - Mark the class datawave.ingest.util.ThreadUtil and its methods as deprecated, with links to their replacements. - Make ThreadUtils.waitForThreads() accept a Consumer<String> log delegate instead of an org.apache.log4j.Logger instance. This makes it far easier for callers to decide how they want to receive and handle status update messages. - Add the method ThreadUtils.blockUntil() to provide the ability to block the current thread until either the supplied condition is true, or a timeout is met. - Add comprehensive unit tests for all methods in ThreadUtils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the class
datawave.concurrent.ThreadUtilsto the common-utils module. This class is intended to be a replacement for datawave.ingest.util.ThreadUtil, placed in a more commonly accessible location.The following changes have also been made:
ThreadUtils.blockUntil()is used in several pending PRs. This PR is to faciliate easier review and smaller change sets in the pending PRs.