Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fat repooler update #13

Merged
merged 5 commits into from
Jun 17, 2016

Conversation

sylvinite
Copy link
Contributor

  • Cleaned up the code
  • Massively increased the info in the summary
  • Rewrote the code to produce pools in the csv file rather than lanes
  • Wrote support for dynamic volume per lane and pool excess volume
  • Sample structure is now dictacted by "most samples that still needs to be sequenced"
  • Coverage of each sample should now be more even
  • Concentration strength is now calculated per sample of each structure rather than per sample for the whole project
  • Statusdb credentials are now set outside the script
  • All data structures have been rewritten to not use magical numbers and just generally behave better

@@ -176,139 +257,155 @@ def aggregator(lane_maps,clusters_rem,clusters_per_lane):
#Ceil(dups) those babies
raise Exception('Error: Not yet implemented!')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've skimmed through this PR. It all looks fine, but since I didn't try to understand what it really does I can't give much feedback. So, it looks good to merge 😎

At this line you can raise NotImplementedError

@remiolsen remiolsen merged commit c84c8e4 into NationalGenomicsInfrastructure:master Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants