Fixed contact mail issue #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you check this by the way? I wrote the code off the top of my head in Slack, so might be worth just checking that it doesn't break stuff 👀 😅 |
Anand and I have tested it now, it works! |
|
Ok great! |
|
@ewels Is the contact email mandatory in our multiqc report? If we implement this, the report will be generated with no contact email, if I'm not wrong. |
|
I'm not really sure why it wouldn't be set? This change just stops MultiQC from crashing if that is the case. But yes it would be better to figure out why it's not being set in the long run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the e-mail contact being none issue as suggested by Phil :-)