Revise OAuth docs to match Readeck API spec and existing codebase#53
Merged
Merged
Conversation
Key corrections: - Fix DTOs to match OpenAPI spec: remove client_id_issued_at, remove expires_in from token response, add id field, fix grant_types type (string not array in response) - Add /info endpoint feature detection step for OAuth capability check - Include clientId in OAuthDeviceAuthorizationState to resolve propagation gap between authorization and polling phases - Reconcile with existing AccountSettingsViewModel/AuthenticateUseCase architecture instead of introducing parallel LoginViewModel - Fix AuthenticationDetails password requirement for OAuth flow - Add completeLogin(url, token) method that fetches username from /profile endpoint - Document client_uri HTTPS constraint and profile:read scope nuance - Add all error codes from API spec enum - Fix token storage description (EncryptedSharedPreferences, not DataStore) - Update Quick Start Checklist with complete ordered task list https://claude.ai/code/session_013U9hn8AEg3N8fpJRyHjPg4
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key corrections:
expires_in from token response, add id field, fix grant_types type
(string not array in response)
propagation gap between authorization and polling phases
architecture instead of introducing parallel LoginViewModel
/profile endpoint
https://claude.ai/code/session_013U9hn8AEg3N8fpJRyHjPg4