Implement improvements for reading progress tracking, manual bookmark sync and log management#48
Merged
Conversation
Treessence's sizeLimit parameter is in bytes, not kilobytes. Setting sizeLimit=128 created 128-byte files, causing immediate rotation after 1-2 log lines. This left file 0 empty and files 1/2 with only a couple of entries each. Changed to 128*1024 (131072 bytes = 128 KB) as originally intended by the spec. https://claude.ai/code/session_01LbMyTbouPGq999Br8XVuEZ
…k-sync-EeiuP Fix log file size limit calculation in MyDeckApplication
NateEaton
changed the title
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements three feature specs from
_notes/:Save reading progress on app close/minimize — Hooks into the Android
onStoplifecycle event to persist article scroll position before the app is backgrounded or killed. Previously, progress was only saved on back-navigation or ViewModel destruction, which the system could skip entirely.Manual bookmark sync — Adds a "Sync Bookmarks Now" button to the Sync Settings screen that triggers an immediate full sync with deletion detection, bypassing the 24-hour gate that scheduled syncs use.
Configurable log retention with enhanced viewer — Adds user-selectable log retention periods (1 day to 3 months) with automatic cleanup on app start, a multi-file log viewer with dropdown file selector, ZIP-based log sharing, and bounded file sizes via Treessence
sizeLimit. Includes a fix for thesizeLimitparameter which is specified in bytes, not kilobytes.Changes
BookmarkDetailViewModel/ lifecycle integration: save scroll progress inonStopFullSyncWorker/FullSyncUseCase: accept force-sync flag to bypass 24-hour intervalSyncSettingsScreen/SyncSettingsViewModel: new sync button with progress stateSettingsDataStore: log retention preference (log_retention_days)MyDeckApplication: automatic log cleanup on startup, corrected TreessencesizeLimitfrom128(bytes) to128 * 1024(128 KB)LoggerUtil: multi-file listing (getAllLogFiles) and ZIP archive creationLogViewViewModel/LogViewScreen: file selector dropdown, retention dialog, ZIP sharingTest plan