Add scrollbar indicator to list views#40
Merged
Conversation
Extend VerticalScrollbar with a LazyListState overload so the existing auto-hide/fade scrollbar can be used on LazyColumn lists. Refactor the shared rendering into a private ScrollbarTrack composable. Integrate the scrollbar into BookmarkListView, LabelsListView, and LogViewScreen by wrapping each scrollable container in a Box with the scrollbar overlaid at CenterEnd. https://claude.ai/code/session_01Qxiav2ee6jYJwUczJ2kCHQ
The LazyColumn content lambdas in BookmarkListView and LabelsListView were not properly closed before the VerticalScrollbar overlay, causing the scrollbar to be placed inside the LazyColumn scope instead of the parent Box scope. https://claude.ai/code/session_01Qxiav2ee6jYJwUczJ2kCHQ
- Remove the extra "Sync Status" title inside SyncStatusSection since the parent layout already renders one above the section call. - Disable background sync completion notifications by adding an early return in showNotification(). The code is preserved (not deleted) for potential future use cases. https://claude.ai/code/session_01Qxiav2ee6jYJwUczJ2kCHQ
Use key(filterState) to scope the LazyListState so that each filter view (My List, Archive, Favorites, Labels) gets an independent scroll position. When the filter changes the previous LazyListState is discarded and a fresh one is created, scrolling back to the top. https://claude.ai/code/session_01Qxiav2ee6jYJwUczJ2kCHQ
Tapping the top bar title (My List, Archive, Favorites, Select Label, Label...) smoothly scrolls the current list back to the top. Uses an integer trigger state incremented on tap, observed via LaunchedEffect in both BookmarkListView and LabelsListView. https://claude.ai/code/session_01Qxiav2ee6jYJwUczJ2kCHQ
Since sync notifications are disabled, there is no reason to request POST_NOTIFICATIONS permission. Add early return to requestBackgroundPermissionIfNeeded() so the permission dialog is never shown (e.g. when using the date range download button). https://claude.ai/code/session_01Qxiav2ee6jYJwUczJ2kCHQ
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend VerticalScrollbar with a LazyListState overload so the existing
auto-hide/fade scrollbar can be used on LazyColumn lists. Refactor the
shared rendering into a private ScrollbarTrack composable.
Integrate the scrollbar into BookmarkListView, LabelsListView, and
LogViewScreen by wrapping each scrollable container in a Box with the
scrollbar overlaid at CenterEnd.
https://claude.ai/code/session_01Qxiav2ee6jYJwUczJ2kCHQ