Refine duplicate URL detection spec after codebase review#118
Merged
NateEaton merged 1 commit intoMar 15, 2026
Conversation
Address implementation gaps identified during feasibility review: - Fix subsection heading levels for proper markdown hierarchy - Specify suspend fun (not Flow) for DAO duplicate lookup - Add ShareActivity architectural approach (local compose state) - Place duplicate fields on CreateBookmarkUiState.Open for in-app path - Expand title match semantics table for blank existing titles - Add navigate-away UX guidance (explicit Open button per row) - Clarify duplicate Open vs View save action relationship - Move url index from optional to required for V2 - Resolve date format: relative within 7 days, absolute after - Remove resolved items from open decisions list https://claude.ai/code/session_01PcGXsUwaCgAm4VvSTavsaC
NateEaton
added a commit
that referenced
this pull request
Mar 16, 2026
* Fix release drawer route matching * Improve label picker multi-select UX * Refine reader settings sheet and theme controls * Restore dynamic reader accents * Improve reader search navigation * Adapt reader settings sheet height * Add duplicate URL detection spec * Add sync architecture optimization spec (#117) Analyzes the current API sync pipeline and proposes targeted fixes for two issues: the ~10s blocking sync spinner on app open, and the N+1 database insert pattern in BookmarkDao. Preserves the existing deferred content load model. Includes phased implementation plan. https://claude.ai/code/session_01WsQFgiU2b4TMFxayW6Q2s7 Co-authored-by: Claude <noreply@anthropic.com> * Refine duplicate URL detection spec after codebase review (#118) Address implementation gaps identified during feasibility review: - Fix subsection heading levels for proper markdown hierarchy - Specify suspend fun (not Flow) for DAO duplicate lookup - Add ShareActivity architectural approach (local compose state) - Place duplicate fields on CreateBookmarkUiState.Open for in-app path - Expand title match semantics table for blank existing titles - Add navigate-away UX guidance (explicit Open button per row) - Clarify duplicate Open vs View save action relationship - Move url index from optional to required for V2 - Resolve date format: relative within 7 days, absolute after - Remove resolved items from open decisions list https://claude.ai/code/session_01PcGXsUwaCgAm4VvSTavsaC Co-authored-by: Claude <noreply@anthropic.com> * Add spec for reader and delete bugfixes (v0.11.1) (#119) * Add mini spec for reader & delete bugfixes (v0.11.1) Covers six items from user feedback: rapid successive delete race condition, text-size shift when margins change, reproducible layout glitch, video fullscreen for article embeds, narrower minimum margin, and theme-switch reflow elimination via CSS custom properties. https://claude.ai/code/session_015xCk9LrWSrxxmCEWudcMkm * Correct spec item #4: embedded videos are stripped server-side The issue is not about fullscreen callbacks for article types — Readeck's extraction pipeline strips iframe/embed tags from article HTML entirely. The video content never reaches the app. Updated to document as a server-side limitation with options for future consideration. https://claude.ai/code/session_015xCk9LrWSrxxmCEWudcMkm * Update spec item #4: video fullscreen UX polish Fullscreen works correctly for all providers. Revised to focus on the actual UX issues: discoverability (non-obvious path to fullscreen) and auto-rotation (sensor-based rotation instead of manual rotate button). Dropped server-side extraction limitation note as out of scope. https://claude.ai/code/session_015xCk9LrWSrxxmCEWudcMkm * Expand spec item #4 with video fullscreen improvements Added four sub-items: app-controlled fullscreen entry for discoverability, enabling "open in service" links by relaxing iframe sandbox, auto-rotation via Activity orientation, and repositioned pill-shaped overlay controls to avoid provider control overlap. https://claude.ai/code/session_015xCk9LrWSrxxmCEWudcMkm --------- Co-authored-by: Claude <noreply@anthropic.com> * Fix reader theming, delete undo, and video controls * Clarify pending delete snackbar target --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address implementation gaps identified during feasibility review:
https://claude.ai/code/session_01PcGXsUwaCgAm4VvSTavsaC