Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Docker baseimage to Python 3.12 #805

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

juhoinkinen
Copy link
Member

Now when Python 3.12 will be fully supported (after #796), lets upgrade to it in Docker image.

The upgrade should bring some performance improvements.

@juhoinkinen juhoinkinen added docker maintenance dependencies Pull requests that update a dependency file labels Sep 30, 2024
@juhoinkinen juhoinkinen added this to the 1.2 milestone Sep 30, 2024
Copy link

sonarcloud bot commented Sep 30, 2024

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (ad6ea7a) to head (59b2fe9).
Report is 48 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #805    +/-   ##
========================================
  Coverage   99.65%   99.65%            
========================================
  Files          93       93            
  Lines        6939     7058   +119     
========================================
+ Hits         6915     7034   +119     
  Misses         24       24            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to test if old models can still be loaded after this.

@juhoinkinen juhoinkinen marked this pull request as ready for review September 30, 2024 09:14
@juhoinkinen
Copy link
Member Author

I checked the projects at ai.dev.finto.fi, and other projects than those using NN ensemble seem to work.

@juhoinkinen juhoinkinen merged commit 1e2c43c into main Sep 30, 2024
17 checks passed
@juhoinkinen juhoinkinen deleted the upgrade-docker-baseimage-to-python3.12 branch September 30, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants