-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically add metadata to Hugging Face Hub repos when uploading projects #793
Automatically add metadata to Hugging Face Hub repos when uploading projects #793
Conversation
About @osma's suggestions in #790 (comment):
|
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
==========================================
+ Coverage 99.64% 99.65% +0.01%
==========================================
Files 91 93 +2
Lines 6817 7058 +241
==========================================
+ Hits 6793 7034 +241
Misses 24 24 ☔ View full report in Codecov by Sentry. |
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit 845f53d)
|
Good point by the AI, but I think the project language is always set if this point is reached...? |
Persistent review updated to latest commit 845f53d |
I added an automatically updating Projects section to the modelcard, like this: https://huggingface.co/juhoinkinen/Annif-models-upload-testing#projects |
Potentially uninitialized local variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of anything to improve; I think we need to find out through actual use whether there is something that could be fixed or made better.
I did find two typos though :)
Quality Gate passedIssues Measures |
PR #793 updated docstring of download command, when docstring of upload should have been updated.
With this PR, when running
annif upload
:README.md
(Model Card) does not exist in the destination repository, thenREADME.md
is created with default contents, project list (containing projects that have configuration (*.cfg
) files in the repo) and some metadata of the uploaded projects,README.md
exists, its project list and metadata are updated as necessary.Closes #790.
The metadata includes these:
The text content is like this (from here https://huggingface.co/juhoinkinen/Annif-models-upload-testing):