Bugfix/np constraints#36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a conditional statement in the
_setup()calls to CVODE and IDA that was preventing numpy arrays from being used for theconstraints_idxandalgebraic_idxoptions. The conditional now just checks that the option is notNoneso anyarray_likecan be used, including numpy arrays.Note: The
mainbranch and recentv1.1.xreleases already had this fix implemented, so this is really just a back port tov1.0.xto resolve a user-posted issue.Fixes #35
Type of change
Key checklist
$ nox -s linter [-- format]$ nox -s codespell [-- write]$ nox -s tests$ nox -s badgesFurther checks:
$ nox -s docs.