Skip to content

Bugfix/np constraints#36

Merged
c-randall merged 5 commits into
v1.0.xfrom
bugfix/np-constraints
Nov 10, 2025
Merged

Bugfix/np constraints#36
c-randall merged 5 commits into
v1.0.xfrom
bugfix/np-constraints

Conversation

@c-randall
Copy link
Copy Markdown
Collaborator

@c-randall c-randall commented Nov 9, 2025

Description

There was a conditional statement in the _setup() calls to CVODE and IDA that was preventing numpy arrays from being used for the constraints_idx and algebraic_idx options. The conditional now just checks that the option is not None so any array_like can be used, including numpy arrays.

Note: The main branch and recent v1.1.x releases already had this fix implemented, so this is really just a back port to v1.0.x to resolve a user-posted issue.

Fixes #35

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that improves speed/readability/etc.)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • No style issues: $ nox -s linter [-- format]
  • Code is free of misspellings: $ nox -s codespell [-- write]
  • All tests pass: $ nox -s tests
  • Badges are updated: $ nox -s badges

Further checks:

  • The documentation builds: $ nox -s docs.
  • Code is commented, particularly in hard-to-understand areas.
  • Tests are added that prove fix is effective or that feature works.

@c-randall c-randall marked this pull request as ready for review November 10, 2025 16:13
@c-randall c-randall merged commit bf310bd into v1.0.x Nov 10, 2025
10 checks passed
@c-randall c-randall deleted the bugfix/np-constraints branch November 10, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant