change ubuntu-18.04 to ubuntu-latest in github actions #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolanaj
approved these changes
Mar 6, 2023
Collaborator
zolanaj
left a comment
zolanaj
left a comment
There was a problem hiding this comment.
My only note here is that if we run into a similar situation in the future, a possible fix will be to revert an older (but not deprecated) version of ubuntu if a breaking change for our test suite is introduced. I think 'latest' is still the best path forward though. Thank you @hdunham for the fix!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Updated ubuntu-18.04 to ubuntu-latest in GitHub push/pull tests because 18.04 was deprecated in GitHub Actions
What is the current behavior?
all GitHub actions are automatically cancelled during "awareness brownouts" and will soon always fail
What is the new behavior (if this is a feature change)?
github actions run again
Does this PR introduce a breaking change?
no
Other information: