Expand AFN summary tables to include all wind directions and coefficients

[rraustad]

Pull request overview

• Fixes Initialization Summary table output AirflowNetwork subtables are incomplete. #6929

Description of the purpose of this PR

AirflowNetwork initialization tables are not populated with all results. This has been corrected to report all wind directions and coefficients.

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
• If adding/removing any output files (e.g., eplustbl.*)
  • Update ..\scripts\Epl-run.bat
  • Update ..\scripts\RunEPlus.bat
  • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
  • Update ...github\workflows\energyplus.py

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[rraustad]

Using example file AirflowNetwork_PressureControl.

Develop:

! <AirflowNetwork Model:Wind Direction>, Wind Direction #1 to n (degree)
AirflowNetwork Model:Wind Direction, 0.0,30.0,60.0,90.0,120.0,150.0,180.0,210.0,240.0,270.0,300.0,330.0
! <AirflowNetwork Model:Wind Pressure Coefficients>, Name, Wind Pressure Coefficients #1 to n (dimensionless)
AirflowNetwork Model:Wind Pressure Coefficients, NFACADE_WPCVALUE, 0.60,0.48,0.04,-0.56,-0.56,-0.42,-0.37,-0.42,-0.56,-0.56,0.04,0.48
AirflowNetwork Model:Wind Pressure Coefficients, EFACADE_WPCVALUE, -0.56,0.04,0.48,0.60,0.48,0.04,-0.56,-0.56,-0.42,-0.37,-0.42,-0.56
AirflowNetwork Model:Wind Pressure Coefficients, SFACADE_WPCVALUE, -0.37,-0.42,-0.56,-0.56,0.04,0.48,0.60,0.48,0.04,-0.56,-0.56,-0.42
AirflowNetwork Model:Wind Pressure Coefficients, WFACADE_WPCVALUE, -0.56,-0.56,-0.42,-0.37,-0.42,-0.56,-0.56,0.04,0.48,0.60,0.48,0.04
AirflowNetwork Model:Wind Pressure Coefficients, HORIZONTAL_WPCVALUE, 0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00

This branch:

! <AirflowNetwork Model:Wind Direction (degrees)>, Wind Direction #1, Wind Direction #2, Wind Direction #3, Wind Direction #4, Wind Direction #5, Wind Direction #6, Wind Direction #7, Wind Direction #8, Wind Direction #9, Wind Direction #10, Wind Direction #11, Wind Direction #12
AirflowNetwork Model:Wind Direction (degrees),0.00,30.00,60.00,90.00,120.00,150.00,180.00,210.00,240.00,270.00,300.00,330.00,360.00
! <AirflowNetwork Model:Wind Pressure Coefficients (dimensionless)>, Name, Coefficient #1, Coefficient #2, Coefficient #3, Coefficient #4, Coefficient #5, Coefficient #6, Coefficient #7, Coefficient #8, Coefficient #9, Coefficient #10, Coefficient #11, Coefficient #12
AirflowNetwork Model:Wind Pressure Coefficients (dimensionless), NFACADE_WPCVALUE, 0.60,0.48,0.04,-0.56,-0.56,-0.42,-0.37,-0.42,-0.56,-0.56,0.04,0.48
AirflowNetwork Model:Wind Pressure Coefficients (dimensionless), EFACADE_WPCVALUE, -0.56,0.04,0.48,0.60,0.48,0.04,-0.56,-0.56,-0.42,-0.37,-0.42,-0.56
AirflowNetwork Model:Wind Pressure Coefficients (dimensionless), SFACADE_WPCVALUE, -0.37,-0.42,-0.56,-0.56,0.04,0.48,0.60,0.48,0.04,-0.56,-0.56,-0.42
AirflowNetwork Model:Wind Pressure Coefficients (dimensionless), WFACADE_WPCVALUE, -0.56,-0.56,-0.42,-0.37,-0.42,-0.56,-0.56,0.04,0.48,0.60,0.48,0.04
AirflowNetwork Model:Wind Pressure Coefficients (dimensionless), HORIZONTAL_WPCVALUE, 0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00

Here's the first row in the table above:

AirflowNetwork:MultiZone:WindPressureCoefficientValues,
  NFacade_WPCValue,        !- Name
  Every 30 Degrees,        !- AirflowNetwork:MultiZone:WindPressureCoefficientArray Name
  0.60,                    !- Wind Pressure Coefficient Value 1 {dimensionless}
  0.48,                    !- Wind Pressure Coefficient Value 2 {dimensionless}
  0.04,                    !- Wind Pressure Coefficient Value 3 {dimensionless}
  -0.56,                   !- Wind Pressure Coefficient Value 4 {dimensionless}
  -0.56,                   !- Wind Pressure Coefficient Value 5 {dimensionless}
  -0.42,                   !- Wind Pressure Coefficient Value 6 {dimensionless}
  -0.37,                   !- Wind Pressure Coefficient Value 7 {dimensionless}
  -0.42,                   !- Wind Pressure Coefficient Value 8 {dimensionless}
  -0.56,                   !- Wind Pressure Coefficient Value 9 {dimensionless}
  -0.56,                   !- Wind Pressure Coefficient Value 10 {dimensionless}
  0.04,                    !- Wind Pressure Coefficient Value 11 {dimensionless}
  0.48;                    !- Wind Pressure Coefficient Value 12 {dimensionless}

[rraustad]

I tried for some time to verify in a unit test that this data was written to tables or sql file without any luck. 2 points for trying.

[github-actions]

⚠️ Regressions detected on macos-14 for commit 00abee4

Regression Summary

• EIO: 35
• Table Big Diffs: 32

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on ubuntu-24.04 for commit 00abee4

Regression Summary

• EIO: 35
• Table Big Diffs: 32

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on macos-14 for commit 1053ecf

Regression Summary

• EIO: 35
• Table Big Diffs: 32

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on ubuntu-24.04 for commit 1053ecf

Regression Summary

• EIO: 35
• Table Big Diffs: 32

• View Results
• Download Regressions

[rraustad]

Example file AirflowNetworkAdvanced_SingleSided_NV does role out the 36 wind directions and coefficients. The table is large so spans off the screen. Here is a section of these tables where more than 12 wind directions and coefficients exist for that example file.

Output:Table:SummaryReports,
  AnnualBuildingUtilityPerformanceSummary,  !- Report 1 Name
  AllSummary;         !- Report 2 Name

[github-actions]

⚠️ Regressions detected on macos-14 for commit 7504624

Regression Summary

• EIO: 35
• Table Big Diffs: 32

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on ubuntu-24.04 for commit 7504624

Regression Summary

• EIO: 35
• Table Big Diffs: 32

• View Results
• Download Regressions

[mitchute]

Thanks @rraustad.

[github-actions]

⚠️ Regressions detected on macos-14 for commit c2ef7f8

Regression Summary

• EIO: 35
• Table Big Diffs: 32

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on ubuntu-24.04 for commit c2ef7f8

Regression Summary

• EIO: 35
• Table Big Diffs: 32

• View Results
• Download Regressions