Merged
Conversation
Collaborator
|
I think the BACnet issue you're hitting in the tests will be fixed by #310 . Is there a way to test that the new RTD configuration works? It looks good to me, but I'm not sure how to check that the build works |
Member
Author
|
You can build locally with... ...which isn't exactly what RTD uses (below) but similar.
We should try to have parity between the local and remote documentation for building the documentation, which I can add to the I ran the following command locally, which is closer to the RTD one and worked... |
Collaborator
gtfierro
approved these changes
May 20, 2024
Collaborator
gtfierro
left a comment
There was a problem hiding this comment.
Ran the builds and it worked great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #315.