Make dependencies easier to manage for development#264
Merged
Conversation
- the "extra" dependencies were not actually marked as optional, so they were all being installed anyway. This make sure they are not installed unless the developer wants them to - "psycopg2" can be difficult to install on some systems like MacOS due to needing to tell the installation process about the location of the libpq library. Now, the much easier "psycopg2-binary" package will be installed as part of the development dependencies. To use postgres in production, one will need to install buildingMOTIF with the "postgres" option/flag which will install the "psycopg2" library which is recommended over "psycopg2-binary" for production.
TShapinsky
requested changes
Jun 29, 2023
Member
TShapinsky
left a comment
TShapinsky
left a comment
There was a problem hiding this comment.
This looks good to me, one typo. This approach seems to align with general guidance about psycopg2
Co-authored-by: Tobias Shapinsky <tobiasshapinsky@gmail.com>
TShapinsky
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devdependency group)@haneslinger the second bullet above should make the BuildingMOTIF easier for our intern to install
@TShapinsky and @MatthewSteen let me know if you have any other ideas on how this could be done. I've updated the docs to reflect this setup