universal waste handling enabled by purboday · Pull Request #18 · NatLabRockies/ABSiCE

purboday · 2026-02-16T23:55:44Z

This PR extends the ABM circular economy model to support universal waste regulations and infrastructure, enabling differentiated waste routing based on regulatory classification (hazardous, universal waste, or regular waste).

Changes

Added storage limits in days and conversion logic for different time steps.
Added support for loading universal waste-specific facilities:
- Universal_Waste_Landfills_data.csv - dedicated landfill sites
- Universal_Waste_Recyclers_data.csv - certified recycling facilities
Consumer agents now route waste to appropriate facilities based on regulatory classification. Added universal waste-specific transportation cost and distance tracking.
Enhanced TCLP test logic to distinguish between hazardous and universal waste.
Implemented storage time limits for universal waste. Added universal waste generator size classification based on annual waste generation.
Created helper functions to identify closest recycler facilities

purboday · 2026-02-16T23:56:39Z

policy_regulation/generator_threshold.csv

@@ -1,9 +1,9 @@
-generator_size,max_storage_kg,max_storage_years,waste_generation_limit_kg,state


Changed the storage time to use days in line with the state regulations.

purboday · 2026-02-16T23:57:18Z

policy_regulation/universal_waste_generator_threshold.csv

@@ -0,0 +1,5 @@
+generator_size,max_storage_kg,max_storage_days,waste_generation_limit_kg,state


Currently this is only used to set the storage time limit for universal waste.

purboday · 2026-02-16T23:58:18Z

TEMP/recycler_data.csv

-Okon Recycling,Texas,Dallas,32.779167,-96.808891,FALSE
-Powerhouse Recycling,North Carolina,Salisbury,35.671,-80.4742,FALSE
-FabTech Solar Solutions,Arizona,Gilbert,33.352763,-111.78904,FALSE
+Recycler Name,State,City,Latitude,Longitude,RCRA permit,Universal Waste Permit


Added a new column for UW to distinguish between recycling facilities.

purboday · 2026-02-16T23:58:59Z

TEMP/Universal_Waste_Landfills_data.csv

@@ -0,0 +1,58 @@
+,Facility Name,Longitude,Latitude,$/ Ton


Added UW landfills in a separate input file

If I understand correctly the list of hazardous landfills is "Landfill_data_SA.csv" and costs are $175/ton and this new file has a longer list of UW landfills with costs of $114/ton. I can't remember what is the source for this new dataset (both list and associated costs) but we will have to document.

purboday · 2026-02-16T23:59:10Z

TEMP/Universal_Waste_Recyclers_data.csv

@@ -0,0 +1,9 @@
+Recycler Name,State,City,Longitude,Latitude,RCRA permit,Universal Waste Permit


Added UW recyclers in a separate input file

Same comment as for the UW landfill file, we will need to document source of those.

purboday · 2026-02-17T00:29:32Z

ABM_CE_PV_ConsumerAgents.py


        self.update_product_storage_hazardous() 
-        if self.is_hazardous_waste_storage_limit_exceeded():
+        if self.is_hazardous_waste_storage_limit_exceeded() or \


Since UW is considered as a subset of hazardous waste, it shares the tracking variables.

purboday · 2026-02-17T00:30:54Z

ABM_CE_PV_ConsumerAgents.py

+            # if not universal_waste_thresholds:
+            #     # If no thresholds are provided, default to SMALL generator size
+            #     self.generator_size = GeneratorSize.SMALL
+            past_year_index = len(self.new_products_hard_copy) - self.model.timestep.value


Gets the past 1 year's waste depending on the time step selected.

I am not sure why self.new_products_hard_copy is being used... I think this variable is a list of installed capacity in W at each time step? It's not the amount of waste stored... why not using a variable linked to the waste generated at each time step? I think this method needs to be revised. Were we using the same logic for Hazardous waste? If so it would also need to be changed.

Looking at the update_universal_waste_generator_size method just above this one. I understand the logic and I think it works well. I am not sure why the logic is so different for update_universal_waste_generator_size. Can't we use the same as for regular hazardous waste?

purboday · 2026-02-17T00:31:24Z

ABM_CE_PV_ConsumerAgents.py

            # based on the TCLP test results.
-            self.hazardous = self.model.tclp_test()
-            self.tclp_test_result = int(self.hazardous)
+            is_tclp_positive = self.model.tclp_test()


We do the TCLP first and if it is hazardous, then we check for universal waste.

purboday · 2026-02-17T00:33:26Z

ABM_CE_PV_ConsumerAgents.py

            if regulator_thresholds[self.generator_size].max_storage_kg is not None:
                self.max_storage_hazardous_kg = regulator_thresholds[self.generator_size].max_storage_kg

+    def _find_closest_recycler_name(self, distance_df):


Used to get the recycler name and the agent id based on the distance. Currently it is used to update the recycler name in case of universal waste.

purboday · 2026-02-17T00:35:30Z

utils.py


    return df_expanded
+
+def get_number_of_days_in_timestep(timestep: TIMESTEP) -> int:


This is used to calculate the storage time limit based on the time step selected. For example using Quarterly time step: 180 days / 90 =2 days = 2 time steps.

Minor comment: 180 days / 90 days per time step = 2 time steps

jwalzberg · 2026-02-22T22:07:54Z

@purboday, I will work on this review on Tuesday.

jwalzberg · 2026-02-25T01:37:46Z

ABM_CE_PV_ConsumerAgents.py

@@ -996,7 +1009,7 @@ def update_product_storage_hazardous(self):
        """
        Update the storage of hazardous products based on the purchase choice.


Minor edit: I think "based on the purchase choice" should be "based on the EoL choice"

jwalzberg · 2026-02-25T01:39:47Z

ABM_CE_PV_ConsumerAgents.py

                    return True
        return False
+
+    def is_universal_waste_storage_limit_exceeded(self):


Could we combine both function (universal waste and hazardous waste limit exceeded checks?). For now let's keep as two separate functions for interest of time but we can revisit later.

jwalzberg · 2026-02-25T01:54:17Z

ABM_CE_PV_ConsumerAgents.py

        """
        if self.hazardous:
            return self.hazardous_landfill_cost + \
                   self.model.hazardous_waste_management_cost['landfill'] / 1E3 * self.model.dynamic_product_average_wght


self.model.hazardous_waste_management_cost['landfill'] is 0 right now. I imagine this is some sort of premium? We know that the total premium (including landfill fee premium and longer distances) should lead to 5-10 times higher total costs. In our notes we found that we needed to change transportation costs to $0.395/t.km instead of $0.095/t.km.

However, if we want to deal with the cost premium differently we could set the self.model.hazardous_waste_management_cost['landfill'] to $300/ton. I think that would be the best way to model the cost premium (i.e. leave transportation costs untouched at $0.095/t.km, use the hazardous and UW landfill fees we have from the csv files and add this cost premium of $300/ton). For UW this cost premium could be $150/ton instead (as we said we can assume a midlle ground value). This cost premium would represent permit costs, aditional skilled labor to handle hazardous waste, etc. for both UW and hazardous waste (with UW representing a lesser burden since permits and so on are easier to deal with).

To make those modifications we could create a new PR once this one is merged as is or just push a new commit before we merge.

jwalzberg · 2026-02-25T01:59:56Z

ABM_CE_PV_ConsumerAgents.py

            return self.hazardous_landfill_cost + \
                   self.model.hazardous_waste_management_cost['landfill'] / 1E3 * self.model.dynamic_product_average_wght
+        elif self.universal_waste:
+            return self.universal_waste_landfill_cost


Half the premium should be added here: self.universal_waste_landfill_cost + (self.model.hazardous_waste_management_cost['landfill'] / 2) / 1E3 * self.model.dynamic_product_average_wght

jwalzberg · 2026-02-25T02:19:18Z

ABM_CE_PV_Model.py

                 landfill_solar_waste_acceptance_ratio=0.4,
                 last_step=31,
                 sa_landfill_costs=(False, 0.0037),
                 file_name={'Landfill data': "Landfills_data_2023.csv",


I can't find the Landfills_data_2023.csv in the TEMP file. Is it because we have it in the gitignore file (becaus eit is proprietary)?

jwalzberg · 2026-02-25T02:31:03Z

ABM_CE_PV_RecyclerAgents.py

+        if not hazardous_recycler_row.empty and hazardous_recycler_row['RCRA permit'].values[0]:
+            self.hazardous = True
+        # Check if the recycler is a universal waste recycler
+        universal_waste_recycler_row = self.model.recycler_data[self.model.recycler_data['Recycler Name'] == self.recycler_name]


It looks like it is using the same variable as for hazardous recyclers: self.model.recycler_data. Checking the ABM_CE_PV_Model.py file, the "Universal_Waste_Recyclers_data.csv" file seems to never be used.

jwalzberg

@purboday, this is really really good! I like all the new pieces that have beed added. I have left several comments that I think need to be addressed (or explained) before we can proceed to the merge though. We can meeto quickly to discuss them at any time although the RTN work is probably more important right now.

universal waste handling enabled

3f5e8ed

purboday commented Feb 17, 2026

View reviewed changes

purboday requested a review from jwalzberg February 17, 2026 00:39

jwalzberg reviewed Feb 25, 2026

View reviewed changes

jwalzberg requested changes Feb 25, 2026

View reviewed changes

		@@ -1,9 +1,9 @@
		generator_size,max_storage_kg,max_storage_years,waste_generation_limit_kg,state

		@@ -0,0 +1,5 @@
		generator_size,max_storage_kg,max_storage_days,waste_generation_limit_kg,state

		@@ -0,0 +1,9 @@
		Recycler Name,State,City,Longitude,Latitude,RCRA permit,Universal Waste Permit


		return df_expanded

		def get_number_of_days_in_timestep(timestep: TIMESTEP) -> int:

		@@ -996,7 +1009,7 @@ def update_product_storage_hazardous(self):
		"""
		Update the storage of hazardous products based on the purchase choice.

Conversation

purboday commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jwalzberg Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jwalzberg Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jwalzberg commented Feb 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jwalzberg Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jwalzberg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

purboday commented Feb 16, 2026 •

edited

Loading

jwalzberg Feb 25, 2026 •

edited

Loading

jwalzberg Feb 25, 2026 •

edited

Loading

jwalzberg Feb 25, 2026 •

edited

Loading