Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing License #250

Closed
tobysmith568 opened this issue Apr 18, 2023 · 2 comments
Closed

Missing License #250

tobysmith568 opened this issue Apr 18, 2023 · 2 comments

Comments

@tobysmith568
Copy link

Hey :)

I can see that a license was added to the project in response to issue #65 however it seems that the license was never configured to be included in your npm package.

You can see in the "Code" view on npmjs.com there's no license file.
https://www.npmjs.com/package/ngx-spinner/v/15.0.1?activeTab=code

Please can you update your build/deploy process so that the file is included as a top-level file in the package?

This is important because your license (the MIT license) states:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

However you yourselves don't include the license with that copy of the software.

This in turn makes it impossible for the consumers of your package to adhere to your license when using build automation tools (like the Angular CLI).

Thanks! :)

@Napster2210
Copy link
Owner

@tobysmith568 This has been fixed in v16. Could you please check and feel free to reopen if it still exists?

@tobysmith568
Copy link
Author

Perfect, thanks :)

CC: @wcroteau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants