block other bots too

[NanderTGA]

So turns out people have been experimenting with TestBot's repeat command, and used it to trigger other bots.
This is not good, as people could for example abuse one bot to trigger another, while the bot that was triggered wouldn't know.
Solution? New option in the constructor: blockBots.
This new option will block anyone who has a prefix or "bot" in their name.
I'll also notify a user when they change their name or join with such a name that they will be ignored due to their name.

[mybearworld]

I'll also notify a user when they change their name or join with such a name that they will be ignored due to their name.

So if a bot joins, all bots using msgroom will send a message saying that they'll be ignored?

[NanderTGA]

Yeah, not the best solution.
How about one bot does that? But what if that one goes offline?
Maybe I should just scrap this stuff.

The way we'll know if a user is a bot is if this pattern can be found in the name: [something here]
All bots have this to indicate a prefix. (or to indicate they are a bot, like this: Yabluzo [BOT])
There's one downside though: something like this user [ADMIN] will also match.
But that doesn't seem that big of a problem since most people will not pretend to be admins.

[mybearworld]

So I'd have to rename toB for that to work?

[NanderTGA]

What's the current name of toB?

[mybearworld]

It's just %toB (whatever). It should probably be clearer that it's a bot, anyways, I wanted to give as much space as possible to statuses.

[NanderTGA]

I think you're the only one who doesn't have this pattern in the name.
How about you rename to [%] toB :)?

[mybearworld]

It would be unfortunate, but if necessary, I'll do it...

[NanderTGA]

Maybe we can have bots send a message 🤖 Beep boop, I'm a bot. My prefix is ${prefix}.
But yet again, a bunch of messages.

So how about we combine the two?
We add an option in the constructor to mark the client as a bot, we check if the bot complies with the name pattern on join, if it doesn't, we send the message.
This should solve the problem.

[NanderTGA]

I have recently gotten back in touch with ctrlz. I am planning to make a proposal to give clients the ability to mark themselves as a bot (and provide their prefix as well), so other bots can ignore them.

[NanderTGA]

This issue is probably not going to be fixed on our side, as we will need to do some weird stuff if we would want to fix this.