This repository was archived by the owner on Jan 24, 2021. It is now read-only.
Optimizaiton of DefaultModelBinderLocator #2361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodejunkie
force-pushed
the
benchmark-defaultmodelbinderlocator
branch
from
42d0a09 to
90d8e3e
Compare
|
|
||
| if (binders != null) | ||
| { | ||
| this.binders = binders.ToArray(); |
There was a problem hiding this comment.
This is the same as my comment on the other issue, but I believe you can do:
this.binders = new ReadOnlyCollection(binders);
This means it will work on the original collection and not copy it to a new one.
There was a problem hiding this comment.
We can't wrap it because it's IEnumerable<T> which means we need to materialize the collection first using either ToList or ToArray.
There was a problem hiding this comment.
As discussed in chat, can't cast the value :(
phillip-haydon
added a commit
that referenced
this pull request
Mar 16, 2016
…derlocator Optimizaiton of DefaultModelBinderLocator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweak while chasing bigger dragons. The
DefaultModelBinderLocatorfigured out which model binder is should use for a specific model type. This is part of a 100k requests sample where model binding is involvedBefore
After
