Remove unable to update groups catch #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Its not hidden at all its displayed in meta while it make it return json all api results should return in json even if its a error, API is also not just for the plugin only |
tadhgboyle
approved these changes
May 8, 2023
It should for expected errors, but I wouldn't say it should still return json for programming errors? There is an actual bug here that is not supposed to ever happen. We happen to have a try-catch here, but usually programming errors wouldn't be catched like this |
Derkades
added a commit
that referenced
this pull request
May 10, 2023
samerton
added a commit
that referenced
this pull request
Sep 28, 2023
* Fix AuthMe enabled value (#3349) * Add all missing languages to the Members module (#3350) * Translated using translate.namelessmc.com Co-authored-by: Knapp Bálint <favorit5503@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/hu/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/hu/ Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Forum * Translated using translate.namelessmc.com Co-authored-by: Dominik Roman <dominikslk9@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/sk/ Translation: NamelessMC/Website - Core * Translated using translate.namelessmc.com Co-authored-by: Wgis <bywgis@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/ru/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-discord-integration/ru/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/ru/ Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Discord Integration Translation: NamelessMC/Website - Forum * Make sure Minecraft Integration is enabled (#3356) * Add Russian translation (#3352) Contributed by @Wgis in a github comment: #3350 (comment) Co-authored-by: Ilya Finogenov <20740613+wgis@users.noreply.github.com> * Translated using translate.namelessmc.com Co-authored-by: NamelessMC Translations <robin+weblate@rkslot.nl> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/nl/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/nl/ Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Members module * Translated using translate.namelessmc.com Co-authored-by: Dominik Roman <dominikslk9@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/sk/ Translation: NamelessMC/Website - Members module * Translated using translate.namelessmc.com Co-authored-by: enno123 <admin@enno123.de> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/de/ Translation: NamelessMC/Website - Members module * Translated using translate.namelessmc.com Co-authored-by: Marcos <marckos03br@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/es/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/es/ Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Members module * Translated using translate.namelessmc.com Co-authored-by: Fjuro <ifjuro@proton.me> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/cs/ Translation: NamelessMC/Website - Members module * Include .htaccess file in release zip (#3362) * Fix missing cache settings (#3361) * Fix user group isssue (#3365) Closes #3363 * Fix forum title/description encoding on edit (#3359) * Remove unable to update groups catch (#3360) * Translated using translate.namelessmc.com Co-authored-by: David Morales <davidmolv16@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/es_419/ Translation: NamelessMC/Website - Members module * Remove placeholder from singular message (#3369) * Fix not being able to see Members page in Navigation settings (#3372) * Translated using translate.namelessmc.com Co-authored-by: enno123 <admin@enno123.de> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/de/ Translation: NamelessMC/Website - Core * Translated using translate.namelessmc.com Co-authored-by: Fjuro <ifjuro@proton.me> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/cs/ Translation: NamelessMC/Website - Core * Translated using translate.namelessmc.com Co-authored-by: Edouard DUCHESNES <edouard@duchesnes.fr> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/fr/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-discord-integration/fr/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/fr/ Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Discord Integration Translation: NamelessMC/Website - Members module * Translated using translate.namelessmc.com Co-authored-by: Marcos <marckos03br@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/es/ Translation: NamelessMC/Website - Core * Translated using translate.namelessmc.com Co-authored-by: Mesutcan Yavuz <mesutcan.yavuz@hotmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/cookie-consent/tr/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/tr/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-discord-integration/tr/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/tr/ Translation: NamelessMC/Website - Cookie Consent Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Discord Integration Translation: NamelessMC/Website - Forum * Translated using translate.namelessmc.com Co-authored-by: Mesutcan Yavuz <mesutcan.yavuz@hotmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/tr/ Translation: NamelessMC/Website - Core * Translated using translate.namelessmc.com Co-authored-by: Maiu <maiuxd77@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/nb_NO/ Translation: NamelessMC/Website - Core * Translated using translate.namelessmc.com Co-authored-by: Dominik Roman <dominikslk9@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/sk/ Translation: NamelessMC/Website - Core * Translated using translate.namelessmc.com Co-authored-by: andreas phillip søndergaard andersen <andreas.andersen1410@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/da/ Translation: NamelessMC/Website - Forum * Fix multi query (#3383) * Add id to default server * Fix multiquery * Fix icon not being properly shown (#3377) * Fix ghost player on status page (#3351) Co-authored-by: Tadhg Boyle <tadhgsmboyle@gmail.com> * Translated using translate.namelessmc.com Co-authored-by: andreas phillip søndergaard andersen <andreas.andersen1410@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/da/ Translation: NamelessMC/Website - Forum * Translated using translate.namelessmc.com Co-authored-by: NamelessMC Translations <robin+weblate@rkslot.nl> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/nl/ Translation: NamelessMC/Website - Core * Translated using translate.namelessmc.com Co-authored-by: Petr Kubinec <petrkubinec9@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/en_US/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/en_US/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/en_US/ Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Forum Translation: NamelessMC/Website - Members module * Translated using translate.namelessmc.com Co-authored-by: untuned <untuned@teamhydra.dev> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/en_US/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/en_US/ Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Members module * Translated using translate.namelessmc.com Co-authored-by: Mert <mert2018cinar@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/tr/ Translation: NamelessMC/Website - Core * Translated using translate.namelessmc.com Co-authored-by: Justman10000 <justmegaliga10000@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/de/ Translation: NamelessMC/Website - Core * Call `compileQueries` only when needed (#3386) * Translated using translate.namelessmc.com Co-authored-by: Justman10000 <justmegaliga10000@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/de/ Translation: NamelessMC/Website - Core * Remove Discord discriminator requirement (#3374) * Fix outdated event * Fix oauth linking for forced integrations (#3395) * Require module autoload file before module init (#3397) * Require module autoload file before module init * Change module loading to require once * Prepare 1.1.1 release (#3399) * Small misc improvements (#3389) * Support custom migration tables * Allow specifying custom migrations directory * PHP 7.4 fix * Consistent parameters and add rollback function * Update Phinx and fix migrations * Tidy strtolower * Phinx feature flags * Make makeWhere function in DB class public * Add new buildAssetPath function to URL class --------- Co-authored-by: Robin Slot <robin+github@rkslot.nl> * Translated using translate.namelessmc.com Co-authored-by: Justman10000 <justmegaliga10000@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/de/ Translation: NamelessMC/Website - Core * Rework user group cache issue (#3398) * Add `PHP_SAPI` checks on scripts (#3403) * Readd deleted term + fix discord oauth link success message (#3406) * Revert deleted language term Removed in a0e9ffb @tadhgboyle * Add success message for linking discord * Translated using translate.namelessmc.com Co-authored-by: enno123 <admin@enno123.de> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/de/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/de/ Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Forum * Fix typo in en_US.json (#3412) * Fix auto verify oauth email (#3413) * Translated using translate.namelessmc.com Co-authored-by: Fjuro <ifjuro@proton.me> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/cs/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/cs/ Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Forum * Translated using translate.namelessmc.com Co-authored-by: Andiv <div2005.kk@gmail.com> Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/ru/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/uk/ Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/ru/ Translation: NamelessMC/Website - Core Translation: NamelessMC/Website - Forum * Rewrite release script to fix checksums in upgrade package (#3414) * Fix forum index showing topics without view other topics permission * Ignore group sync request instead of returning error (#3433) * Ignore group sync request instead of returning error * Fix condition * Remove return * Limit logs & Support group sync from modules (#3426) * Limit logs * Support group sync from modules * Ignore adding group if its invalid (#3436) * Ignore adding group if its invalid (#3436) * Fix phpdoc build, pin version (#3438) * Fix single/double quote not working within member list username CSS (#3427) * Prepare 2.1.2 release --------- Co-authored-by: DominikSLK <74055080+DominikSLK@users.noreply.github.com> Co-authored-by: PadowYT2 <me@padow.ru> Co-authored-by: Knapp Bálint <favorit5503@gmail.com> Co-authored-by: Dominik Roman <dominikslk9@gmail.com> Co-authored-by: Wgis <bywgis@gmail.com> Co-authored-by: Partydragen <adrian_kili@outlook.com> Co-authored-by: Robin <robin+git@rkslot.nl> Co-authored-by: Ilya Finogenov <20740613+wgis@users.noreply.github.com> Co-authored-by: NamelessMC Translations <robin+weblate@rkslot.nl> Co-authored-by: enno123 <admin@enno123.de> Co-authored-by: Marcos <marckos03br@gmail.com> Co-authored-by: Fjuro <ifjuro@proton.me> Co-authored-by: David Morales <davidmolv16@gmail.com> Co-authored-by: Tadhg Boyle <tadhgsmboyle@gmail.com> Co-authored-by: Edouard DUCHESNES <edouard@duchesnes.fr> Co-authored-by: Mesutcan Yavuz <mesutcan.yavuz@hotmail.com> Co-authored-by: Maiu <maiuxd77@gmail.com> Co-authored-by: andreas phillip søndergaard andersen <andreas.andersen1410@gmail.com> Co-authored-by: Supercrafter100 <58982133+supercrafter100@users.noreply.github.com> Co-authored-by: Petr Kubinec <petrkubinec9@gmail.com> Co-authored-by: untuned <untuned@teamhydra.dev> Co-authored-by: Mert <mert2018cinar@gmail.com> Co-authored-by: Justman10000 <justmegaliga10000@gmail.com> Co-authored-by: Robin Slot <robin+github@rkslot.nl> Co-authored-by: Andiv <div2005.kk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching all exceptions and returning a custom 500 error doesn't seem to improve API usability, and it hides valuable debug info. If the API returns a stack trace, the plugin will show it to the user making bug reports easier.