Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow correct webhook action types in endpoint #3326

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

supercrafter100
Copy link
Member

The webhook types are numbers (1 = normal, 2 = discord) but these types were not accepted in the createwebhook endpoint. This fixes that

@supercrafter100 supercrafter100 added this to the 2.1.0 milestone Apr 23, 2023
@supercrafter100 supercrafter100 requested a review from a team April 23, 2023 18:52
@tadhgboyle
Copy link
Member

Would be nice to maybe make these constants in some class, like Webhook::TYPE_NORMAL, Webhook::TYPE_DISCORD

@tadhgboyle tadhgboyle merged commit 192793d into develop Apr 24, 2023
@tadhgboyle tadhgboyle deleted the fix/create-webhook-endpoint branch April 24, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants