Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue system #3274

Merged
merged 13 commits into from
Mar 30, 2023
Merged

Queue system #3274

merged 13 commits into from
Mar 30, 2023

Conversation

samerton
Copy link
Member

@samerton samerton commented Mar 4, 2023

  • Create new queue system which allows for tasks to be scheduled and run in the background (using AJAX or cron)

@samerton samerton marked this pull request as ready for review March 27, 2023 18:40
@samerton
Copy link
Member Author

Screenshot 2023-03-27 at 19 31 05

Forum post HTML seems fine after running the convert forum post task

Copy link
Member

@tadhgboyle tadhgboyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, what kind of additions to our documentation do you think we need?

  • Cron file example
  • Module task creation example
  • ...

@tadhgboyle
Copy link
Member

A few more thoughts (will add to this comment if more come up):

  • How can modules define that a task should repeat, and on a specific schedule?
  • It would probably be nice if we displayed somewhere "last cron task execution: xyz", so that people can easily see if their cron file config worked (i recall this being a pain point for the tebex module cron file)

@samerton
Copy link
Member Author

A few more thoughts (will add to this comment if more come up):

  • How can modules define that a task should repeat, and on a specific schedule?
  • It would probably be nice if we displayed somewhere "last cron task execution: xyz", so that people can easily see if their cron file config worked (i recall this being a pain point for the tebex module cron file)

The idea for now is that a task is responsible for rescheduling itself if needed, we could maybe look at changing this in the future depending on how we get on with the current system

Agreed RE cron, I'll create a follow-up PR showing when the queue was last run and also prepare to add something to the docs with an example cron

@samerton samerton merged commit 1589b76 into develop Mar 30, 2023
@samerton samerton deleted the feature/queues branch March 30, 2023 17:42
@samerton samerton added this to the 2.1.0 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants