-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to query servers via plugin #3244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May add the server version as well if this gets implemented in the plugin data sender. Currently works as is though. |
tadhgboyle
requested changes
Feb 1, 2023
tadhgboyle
reviewed
Feb 2, 2023
tadhgboyle
reviewed
Feb 2, 2023
tadhgboyle
previously approved these changes
Feb 4, 2023
tadhgboyle
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are limited to the query port of a server being open for getting information to display on the status page. This is quite limiting in a few ways.
This pull request adds the ability to use the plugin as a method of querying. The plugin sends information about the server anyways so we can use this information to get an idea of the server being online and use information about the server which gets sent anyways like the online player count, player list, etc.