Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panel template "Find Templates" section #3196

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

tadhgboyle
Copy link
Member

Since we no longer provide backwards compatibility to panel templates, and very few (if any) people use them, we are removing this section. There are none posted on the namelessmc marketplace at the moment anyways.

@tadhgboyle tadhgboyle added this to the 2.0.x milestone Jan 16, 2023
@Derkades
Copy link
Member

Backporting this to 2.0.x will break panel templates, but I assume that is intentional given the content of this PR :-)

@tadhgboyle
Copy link
Member Author

Backporting this to 2.0.x will break panel templates, but I assume that is intentional given the content of this PR :-)

Exactly!

@samerton
Copy link
Member

I think if that's the idea, we should add a migration to reset the panel template back to default, otherwise people won't be able to access the panel templates tab to disable their custom template.

@partydragen
Copy link
Member

@partydragen partydragen reopened this Jan 17, 2023
@partydragen
Copy link
Member

I think if that's the idea, we should add a migration to reset the panel template back to default, otherwise people won't be able to access the panel templates tab to disable their custom template.

Panel templates page and functions will still be there, this is only about removing "Find Templates" section

@samerton
Copy link
Member

Will the removal of the variables in the page PHP file not break any template files referring to them?

@partydragen
Copy link
Member

Will the removal of the variables in the page PHP file not break any template files referring to them?

No, All of this is just for the resource listing, the list of template suggestions from NamelessMC website

@samerton
Copy link
Member

This does seem to be a breaking change for users using custom panel templates - tested and the attached screenshot is the result (white screen).

We'll need the migration or to push this back to 2.1.0

Screenshot 2023-01-17 at 16 56 03

@tadhgboyle
Copy link
Member Author

Ah in that case I think pushing to 2.1.0 is fine! Good catch

@Derkades Derkades modified the milestones: 2.0.x, 2.1.0 Jan 17, 2023
@Derkades Derkades merged commit d356f7f into develop Jan 19, 2023
@Derkades Derkades deleted the remove-panel-template-find branch January 19, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants