Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show message if there was an error loading a widget #3138

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Show message if there was an error loading a widget #3138

merged 2 commits into from
Dec 16, 2022

Conversation

samerton
Copy link
Member

No description provided.

@samerton samerton added this to the 2.1.0 milestone Dec 14, 2022
tadhgboyle
tadhgboyle approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@tadhgboyle tadhgboyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, but could it go in for 2.0.x?
I guess the main BC here is the change to Widgets constructor, but this is an internal class so I don't think we risk breaking any modules

@Derkades
Copy link
Member

Derkades commented Dec 15, 2022 •
edited
Loading

This is really great, but could it go in for 2.0.x? I guess the main BC here is the change to Widgets constructor, but this is an internal class so I don't think we risk breaking any modules

Does it break if a third party template is missing the widgets/widget_error.tpl file?

@tadhgboyle
Copy link
Member

This is really great, but could it go in for 2.0.x? I guess the main BC here is the change to Widgets constructor, but this is an internal class so I don't think we risk breaking any modules

Does it break if a third party template is missing the widgets/widget_error.tpl file?

Ah good point

@Derkades Derkades merged commit 6c56264 into develop Dec 16, 2022
@Derkades Derkades deleted the feature/error-widget branch December 16, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partydragen partydragen partydragen approved these changes

@tadhgboyle tadhgboyle tadhgboyle approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@samerton @Derkades @tadhgboyle @partydragen