Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use OAuth linking method for Discord Integration #3051

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

partydragen
Copy link
Member

No description provided.

@partydragen partydragen marked this pull request as ready for review August 23, 2022 20:23
tadhgboyle
tadhgboyle previously approved these changes Sep 12, 2022
@tadhgboyle
Copy link
Member

Should we possibly use this PR to remove the /verify Discord command and instead always use OAuth for linking Discord?

@partydragen
Copy link
Member Author

Should we possibly use this PR to remove the /verify Discord command and instead always use OAuth for linking Discord?

Well idk i fell setting up oauth2 is a bit complicated for less advanced users
but this do solve the issue of people posting the verify key in the chat channel etc, as currently copy/paste the command into discord chat is currently not supported it being posted as a normal chat message

thats a mistake ALOT of people don't understand and they leak the code with allow alot of users to claim the code before they understand they cannot copy/paste the entire command

@tadhgboyle
Copy link
Member

Yeah there are certainly pros and cons either way

@partydragen partydragen merged commit b31e859 into develop Sep 27, 2022
@partydragen partydragen deleted the oauth-option-discord-integration branch September 27, 2022 17:20
@Derkades Derkades added this to the 2.1.0 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants