Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert error page to Fomantic UI #3029

Merged
merged 16 commits into from
Sep 30, 2022
Merged

Convert error page to Fomantic UI #3029

merged 16 commits into from
Sep 30, 2022

Conversation

tadhgboyle
Copy link
Member

@tadhgboyle tadhgboyle commented Aug 14, 2022 •
edited
Loading

image

Screen Shot 2022-08-14 at 13 38 45

PadowYT2
PadowYT2 suggested changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@PadowYT2 PadowYT2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, maybe make the debug link a little higher, so it doesn't take its own space?

@tadhgboyle tadhgboyle force-pushed the feat/error-page-fomantic branch from 932ec67 to 848899d Compare September 24, 2022 22:21
@tadhgboyle tadhgboyle marked this pull request as ready for review September 25, 2022 01:10
@tadhgboyle tadhgboyle requested review from a team and PadowYT2 September 25, 2022 01:11
samerton
samerton reviewed Sep 25, 2022
View reviewed changes
@tadhgboyle tadhgboyle requested review from samerton, PadowYT2 and a team and removed request for PadowYT2 September 26, 2022 02:41
@tadhgboyle tadhgboyle added enhancement design Related to CSS or design labels Sep 28, 2022
@tadhgboyle tadhgboyle added this to the 2.0.x milestone Sep 28, 2022
@tadhgboyle tadhgboyle force-pushed the feat/error-page-fomantic branch from fa1ad9c to 46ccb23 Compare September 28, 2022 03:57
PadowYT2
PadowYT2 previously approved these changes Sep 28, 2022
View reviewed changes
@tadhgboyle tadhgboyle enabled auto-merge (squash) September 30, 2022 00:06
@tadhgboyle tadhgboyle merged commit 112cb2c into develop Sep 30, 2022
@tadhgboyle tadhgboyle deleted the feat/error-page-fomantic branch September 30, 2022 19:07
@supercrafter100 supercrafter100 linked an issue Oct 7, 2022 that may be closed by this pull request
Update exception page to Fomantic UI #2887
Closed
tadhgboyle added a commit that referenced this pull request Oct 15, 2022
@tadhgboyle
Convert error page to Fomantic UI (#3029)
878f18b
@Derkades Derkades modified the milestones: 2.0.x, 2.1.0 Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partydragen partydragen partydragen approved these changes

@PadowYT2 PadowYT2 PadowYT2 left review comments

@samerton samerton Awaiting requested review from samerton

Assignees
No one assigned
Labels
design Related to CSS or design enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Update exception page to Fomantic UI
5 participants
@tadhgboyle @samerton @partydragen @PadowYT2 @Derkades