Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error showing when logging in with OAuth #3015

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

tadhgboyle
Copy link
Member

The error occurred when OAuth login was successful and it tried to redirect them to the previous page. Since "oauth" was not a page to be ignored while storing the last_page session variable, it would attempt to redirect it to the oauth.php file again, which threw the error since there was no provider in the URL params.

@tadhgboyle tadhgboyle added the bug label Aug 13, 2022
@tadhgboyle tadhgboyle added this to the 2.0.x milestone Aug 13, 2022
@tadhgboyle tadhgboyle requested review from partydragen and a team August 13, 2022 04:41
@samerton samerton changed the base branch from v2 to release/2.0.2 August 13, 2022 09:56
@samerton samerton merged commit 26d5cc0 into release/2.0.2 Aug 13, 2022
@samerton samerton deleted the fix/oauth-login-error branch August 13, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants