Better missing/extra migration exception page #3005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a site is missing migrations, we [I] do three things that are not ideal:
core/migrations
table and thenl2_phinxlog
tableThis change checks the file names and compares them to the phinxlog table contents, and prints the issues clearly in plain text so they do not need to check their logs.
The page is in plaintext since other fatal issues (wrong php version, missing vendor dir, etc) are also plaintext.
Finally, this is still much faster than forcing phinx to migrate on every page load: