🔥 Remove support for custom panel templates #2995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadhgboyle
force-pushed
the
fix/remove-custom-panel-templates
branch
from
3978b15 to
e6a7013
Compare
tadhgboyle
changed the title
|
😶 |
samerton
previously approved these changes
Aug 7, 2022
PadowYT2
previously approved these changes
Aug 8, 2022
supercrafter100
previously approved these changes
Aug 11, 2022
|
A good alternate proposal from @partydragen is to display a warning in StaffCP that panel templates have no compatibility promise. |
yes 🎉 |
tadhgboyle
dismissed stale reviews from supercrafter100, PadowYT2, and samerton
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have talked internally about this change, and decided unanimously that it is worth it.
The biggest reason is that removing custom panel template support means we can make changes to the panel template in a minor release, since we will not have to worry about breaking other custom panel templates. This will allow us to release updates to site configuration faster and more often!
Requires NamelessMC/debug.namelessmc.com#175