Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add croatian language #2990

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Add croatian language #2990

merged 1 commit into from
Aug 7, 2022

Conversation

Derkades
Copy link
Member

@Derkades Derkades commented Aug 6, 2022

No description provided.

@tadhgboyle
Copy link
Member

For my own understanding, why is this going to v2 instead of release/2.0.2?

@Derkades
Copy link
Member Author

Derkades commented Aug 6, 2022

I thought everything should be going to the v2 ("development") branch, and then if deemed important enough backported to existing release branches? Like a release branch for 2.0.x, 2.1.x, 2.2.x, 2.3.x, as discussed previously. I'm not sure why the release/2.0.2 branch exists.

@tadhgboyle
Copy link
Member

@samerton ?

@partydragen
Copy link
Member

v2 was for releases only with is even why v2 branch is protected and requires pull request reviews

@tadhgboyle tadhgboyle changed the base branch from v2 to release/2.0.2 August 7, 2022 03:36
with path.open('bw+') as f:
f.write(b'{}\n')

print("Done. Don't forget to add the language to core/classes/Language/Language.php")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will be handy

@tadhgboyle tadhgboyle merged commit eee47b3 into release/2.0.2 Aug 7, 2022
@tadhgboyle tadhgboyle deleted the add-croatian-lang branch August 7, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants