Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-string config values not saving properly #2983

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Fix non-string config values not saving properly #2983

merged 1 commit into from
Aug 6, 2022

Conversation

samerton
Copy link
Member

@samerton samerton commented Aug 6, 2022

Fixes issue where friendly URLs, force HTTPS, force WWW were saving into config as '1' and '0' instead of true and false

@samerton samerton changed the base branch from v2 to release/2.0.2 August 6, 2022 14:24
@partydragen
Copy link
Member

partydragen commented Aug 6, 2022 •
edited
Loading

Why are we switching back?

$loc = is_string($value) ? addslashes($value) : $value; this was the way that not worked
but now we use same way just switched they around so true is last?

@tadhgboyle tadhgboyle merged commit 05fc221 into release/2.0.2 Aug 6, 2022
@tadhgboyle tadhgboyle deleted the bugfix/non-string-config-values branch August 6, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Derkades Derkades Derkades approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samerton @partydragen @Derkades @tadhgboyle