Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Custom Logo Badges #28

Merged
merged 7 commits into from
Mar 15, 2021
Merged

Conversation

GabriOliv
Copy link
Contributor

Add "Custom Logo" Section:

  • add how to create badges with custom logo using Base64 images and Shields.io
  • add examples of badges with custom logo
  • update README.md
  • update README.rst

Fix:

  • fixed broken link line in README.rst

GabriOliv and others added 7 commits March 15, 2021 00:47
docs add title 'Bagdes with Custom Logo' to README.md
docs add 'How to Create'-'Custom Logo' to README.md
docs add example -'Custom Logo' to README.md
docs add 'Custom Logo' - 'Table of content' to README.md
docs update README.rst
docs fix link line 'Meta badge' - README.rst
docs update README.md
@Naereen
Copy link
Owner

Naereen commented Mar 15, 2021

Hi @GabriOliv,
It looks good.

  • Could you check on your branch to see that the <details>...</details> markup with Markdown inside works fine on the GitHub (automatic) preview for the new README.md file please? I have tried it elsewhere and was sometimes disappointed to see that inside it only pure HTML was allowed. Please include a screenshot if you can, here by replying with a comment.

  • Also maybe there are too many examples and it will take too much vertical space (horizontal space is fine). Can you check that the markdown code is well displayed in one line, and not many lines?

Thanks

@GabriOliv
Copy link
Contributor Author

Task 1:


pr_git_001

pr_git_002


Task 2:

pr_git_003

@Naereen
Copy link
Owner

Naereen commented Mar 15, 2021

Great! Thanks!

@Naereen Naereen merged commit a2e1263 into Naereen:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants