Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tables from diagram #7

Merged
merged 4 commits into from
Aug 18, 2022
Merged

Add tables from diagram #7

merged 4 commits into from
Aug 18, 2022

Conversation

NabilHY
Copy link
Owner

@NabilHY NabilHY commented Aug 17, 2022

Hello, Thanks for reviewing this Branch 👍
The following additions were made :

Created the schema_based_on_diagram.sql file to interpret the database diagram provided, and implement the SQL needed to build the database
Joined tables that has many_to_many relationships

Copy link

@muneebulrehman muneebulrehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NabilHY ,

Good job so far! I see you put a lot of effort into this project. However, there are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • Descriptive PR

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment on lines 1 to 46
CREATE TABLE patients (
id serial NOT NULL ,
name VARCHAR(250),
date_of_birth DATE,
PRIMARY KEY (id)
);

CREATE TABLE treatments (
id serial NOT NULL ,
type VARCHAR(250),
name VARCHAR(250),
PRIMARY KEY (id)
);

CREATE TABLE medical_histories (
id serial NOT NULL,
admitted_at TIMESTAMP,
patient_id INTEGER REFERENCES patients(id),
STATUS VARCHAR(250),
PRIMARY KEY (id),
FOREIGN KEY (patient_id) REFERENCES patients(id)
);

CREATE TABLE invoices (
id serial NOT NULL,
total_amount DECIMAL,
generated_at TIMESTAMP,
payed_at TIMESTAMP,
medical_history__id INT,
PRIMARY KEY (id),
FOREIGN KEY (medical_history__id) REFERENCES medical_histories(id)
);

CREATE TABLE invoice_items (
id serial NOT NULL,
unit_price DECIMAL,
quantity INT,
total_price DECIMAL,
invoice_id INT,
treatment_id INT,
PRIMARY KEY (id),
FOREIGN KEY (invoice_id) REFERENCES invoices(id),
FOREIGN KEY (treatment_id) REFERENCES treatments(id)
);


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a join table as per the diagram provided. Consider adding it 😊
image

Copy link

@zieeco zieeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status: APPROVED 🟢 💯

Hi, @NabilHY,

Good job so far 👍 Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@NabilHY NabilHY merged commit b2445a2 into main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants