Refactored enapi to post_build #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seritools
approved these changes
Jul 11, 2024
enunion-helper/src/lib.rs
Outdated
Comment on lines
14
to
16
| let build_dir = PathBuf::from(".").join(enunion_target_path); | ||
| let enunion_path = build_dir.join("enunion-generated-ts"); | ||
| let ts_file_path = build_dir.join("index.d.ts"); |
There was a problem hiding this comment.
- please make
build_dirandts_file_pathconfigurable/fully passed in via parameter. assuming "." or the name of the output file etc is not helpful
beborngod
force-pushed
the
post-build-helper
branch
from
2ab0f4e to
b5dc83a
Compare
seritools
approved these changes
Jul 15, 2024
beborngod
force-pushed
the
post-build-helper
branch
from
b5dc83a to
3b59564
Compare
beborngod
force-pushed
the
post-build-helper
branch
from
3b59564 to
3ab5bdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.