Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dynamic stencil reference to command list #42

Closed
wants to merge 2 commits into from
Closed

Added dynamic stencil reference to command list #42

wants to merge 2 commits into from

Conversation

01Pollux
Copy link

It's convenient to dynamically set stencil reference rather than recompiling the same pipelinestate object.

Copy link

github-actions bot commented Dec 22, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@01Pollux
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

apanteleev added a commit that referenced this pull request Feb 8, 2024
…csState and MeshletState.

Inspired by #42
Also fixed some bugs around shading rate on Vulkan and state caching for blendFactor in meshlet pipelines on DX12.
@apanteleev
Copy link
Contributor

Thank you for the contribution. We decided that it's better to integrate the dynamic stencil ref into the GraphicsState and MeshletState objects, rather than adding a setter method to the command list. That change is now implemented in main; closing this PR.

@apanteleev apanteleev closed this Feb 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants