Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_SNORM format should be signed format in format-info.cpp #43

Closed
BlurryLight opened this issue Jan 21, 2024 · 1 comment
Closed

_SNORM format should be signed format in format-info.cpp #43

BlurryLight opened this issue Jan 21, 2024 · 1 comment

Comments

@BlurryLight
Copy link
Contributor

https://github.com/NVIDIAGameWorks/nvrhi/blob/0884149e43e8e1aa9b0bb2f6ea36122b8cb3f9ad/src/common/format-info.cpp#L34C8-L34C147
image

I noticed all _SNORM formats have false label in signed column of the c_FormatInfo. _SNORM can be negative and as the name suggests, Signed Normalization.

I'm not sure if it's a copy-paste typo or a weired design.
apanteleev added a commit that referenced this issue Jan 23, 2024
@apanteleev
Fixed the isSigned flag on SNORM resources in the format info table (#43
6225145 
)
@apanteleev
Copy link
Contributor

This was a copy-paste typo, now fixed for all SNORM formats. Thanks for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apanteleev @BlurryLight