Ignore some errors on ShapeNet #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caenorst
changed the title
Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com>
Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com>
Caenorst
force-pushed
the
cfujitsang/shapenet-materials
branch
from
021e882
to
2d0b987
Compare
JerryJiehanWang
approved these changes
Apr 30, 2021
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShapeNet has some errors while loading materials because of bad path / missing texture file etc... using
skip_error_handlerwould spam too many warnings, so implemented a new error handler that just ignores those errors.Fix an issue on material_order output by
obj.import_mesh