Refactoring Schema #198
Merged
Refactoring Schema #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcromeyn
force-pushed
the
schema/updates
branch
from
71250d6 to
da861c8
Compare
marcromeyn
force-pushed
the
schema/updates
branch
from
e9c13d5 to
2d1fe86
Compare
Co-authored-by: Ben Frederickson <github@benfrederickson.com>
mikemckiernan
pushed a commit
to mikemckiernan/Transformers4Rec
that referenced
this pull request
Nov 15, 2022
* Experimenting with ways to define a Schema * Adding create_continuous * Adding create_continuous * Adding prototext support * Refactoring Schema * Fixing flake8 * Updating requirements * Trying to fix failing tests * Fixing failing schema tests * Fixing failing schema tests * Change call of from_proto_txt to new signature * Rename Tags to Tag like it was before * Fixing test_tabular_features_yoochoose_direct * Update tests/utils/test_schema.py Co-authored-by: Ben Frederickson <github@benfrederickson.com> * Fixes according to PR-comments * Running flake8 * Adding copyright + some basic tag tests * Some more updates * Some small refactorings of Schema * Some more tests * Trying to fix failing tests Co-authored-by: Ben Frederickson <github@benfrederickson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for users to define a schema manually in code. An example of that:
I will add more docs around this in a future PR, but will merge this now to make sure all our examples/tutorials can already make use of the updated schema.