Quick start for Ranking - Include support for Triton inference #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Documentation preview |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…rlin/Merlin into quick_start_inf_triton
…uick_start_inf_triton
…rlin/Merlin into quick_start_inf_triton
rnyak
changed the title
19 tasks
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
|
rerun tests |
| @@ -0,0 +1,530 @@ | |||
| { | |||
There was a problem hiding this comment.
- We could extract
INPUT_FOLDERto a variable, so that users understand that path is something they could change. - I think that the
/workspaceis not a standard path inside the container, it is the one you mapped and provided to thepreprocessing.py --output_pathright? Inranking.mdwe setOUT_DATASET_PATH=/outputs/dataset
Reply via ReviewNB
There was a problem hiding this comment.
@rnyak I think we need to add a short section in the bottom of the main Quick-start for ranking page linking to the inference/README.md, like we do for the Hyperparameter tuning section.
There was a problem hiding this comment.
@rnyak I think we need to add a short section in the bottom of the main Quick-start for ranking page linking to the inference/README.md, like we do for the Hyperparameter tuning section.
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
gabrielspmoreira
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #919, closes #912, closes #913, closes #914