Skip to content

Threading - #31

Closed
jdonszelmann wants to merge 15 commits into
masterfrom
threading
Closed

Threading#31
jdonszelmann wants to merge 15 commits into
masterfrom
threading

Conversation

@jdonszelmann

@jdonszelmann jdonszelmann commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator

Fixes: #18

@codecov

codecov Bot commented Oct 6, 2020

Copy link
Copy Markdown

Codecov Report

Merging #31 into master will decrease coverage by 3.70%.
The diff coverage is 91.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   98.71%   95.00%   -3.71%     
==========================================
  Files           5        6       +1     
  Lines         699      701       +2     
==========================================
- Hits          690      666      -24     
- Misses          9       35      +26     
Impacted Files Coverage Δ
src/with_threads_alloc.rs 0.00% <0.00%> (ø)
src/with_alloc.rs 95.18% <91.89%> (-3.38%) ⬇️
src/ringbuffer_trait.rs 96.36% <93.54%> (-3.64%) ⬇️
src/lib.rs 100.00% <100.00%> (ø)
src/with_const_generics.rs 92.72% <100.00%> (+1.06%) ⬆️
src/with_generic_array.rs 92.98% <100.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64f3f48...c0bfc4a. Read the comment docs.

@jdonszelmann

Copy link
Copy Markdown
Collaborator Author

@vgel Hey there! I think I merged it correctly now. Your drop tests pass :). I Added the same MaybeUninit code to the AllocRingbuffer because when the buffer gets full it may need to replace items with uninitialized items. Thanks again for the help!

@jdonszelmann

Copy link
Copy Markdown
Collaborator Author

It's now possible to pre-initialize the AllocRingbuffer with Maybeuninit items. That might make the AllocRingBuffer a little faster.

Comment thread Cargo.toml Outdated
[package]
name = "ringbuffer"
version = "0.4.0"
version = "1.1.0"

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.4.0 will be the next release not 1.1.0

Comment thread benches/bench.rs Outdated
c.with_plots();

generate_benches![
generat_benches![

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, should be generate_benches

Comment thread src/lib.rs
// #[cfg(all(feature = "alloc", feature = "threads"))]
// mod with_threads_alloc;
// #[cfg(all(feature = "alloc", feature = "threads"))]
// pub use with_threads_alloc::ThreadAllocRingBuffer;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove or uncomment

Comment thread src/with_threads_alloc.rs
/// // TODO: Example
/// ```
#[derive(PartialEq, Eq, Debug)]
pub struct ThreadAllocRingBuffer<T> {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to add this in the future so for now I suggest we branch from this branch, remove the threaded code an make a new PR?

@jdonszelmann jdonszelmann changed the title Threading Refactor Oct 13, 2020
@jdonszelmann jdonszelmann changed the title Refactor Thrading Oct 13, 2020
@NULLx76
NULLx76 marked this pull request as draft October 13, 2020 11:18
@NULLx76 NULLx76 changed the title Thrading Threading Oct 13, 2020
@NULLx76 NULLx76 closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ringbuffer pairs

2 participants