doing some changes to trigger the mails in my own created cluster - #12
Open
Hariprasad1524 wants to merge 7 commits into
Open
doing some changes to trigger the mails in my own created cluster#12Hariprasad1524 wants to merge 7 commits into
Hariprasad1524 wants to merge 7 commits into
Conversation
Member
|
Thank you for your interest in contributing. However, we prefer not to complicate our maintenance burden with deployment-time choices that don't apply to our project and don't have a demonstrated community. As such, the docker/cron specifics are better suited to maintenance in your own permanent fork rather than as a PR. Something like externalizing variables to env vars makes sense. Most of the rest of this does not. |
JoeGermuska
reviewed
Jul 20, 2026
| msg = EmailMessage() | ||
| msg['From'] = SENDER_EMAIL | ||
| msg['To'] = recipients | ||
| msg['To'] = ", ".join(recipients) |
Member
There was a problem hiding this comment.
if recipients is a string instead of a list, this would incorrectly introduce commas between each character
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.