Join page and instructions #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This pull request introduces a new instructions page detailing the membership application process, updates the join page to link to the new instructions, and adds a component for generating Discord user links.
- Updated the join page (join.vue) to replace the Discord and email links with a button that navigates to the instructions page.
- Created a new instructions page (Instructions.vue) to outline the membership process.
- Introduced a new component (DC.vue) to render Discord user link elements.
Reviewed Changes
| File | Description |
|---|---|
| app/pages/join.vue | Replaced existing contact links with a NuxtLink button to the instructions page. |
| app/pages/Instructions.vue | Added a new page containing membership application instructions and guidance. |
| app/components/DC.vue | Added a new component for displaying a styled Discord user link. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
app/pages/Instructions.vue:9
- The computed property 'formUrl' is defined but not used anywhere in the template. Consider removing it if it is not planned for future use.
formUrl() { return 'https://docs.google.com/forms/d/e/1FAIpQLSciz2ZVjV-yBNIurfYDtsof0ZSiqwXm0-oQlxZwwdmp6wnF_Q/viewform?usp=pp_url' }
This comment was marked as outdated.
This comment was marked as outdated.
…structions.vue and join.vue
kevinlee-06
changed the title
|
|
There was a problem hiding this comment.
PR Overview
This PR updates the join page to redirect users from a Discord/email call-to-action to an instructions page and introduces the instructions page along with a Discord link component.
- Updated text and navigation in app/pages/join.vue
- Added a new instructions page in app/pages/Instructions.vue
- Introduced app/components/DC.vue for generating Discord profile links
Reviewed Changes
| File | Description |
|---|---|
| app/pages/join.vue | Changed text from "我們的一員" to "NPC" and updated button link to point to the instructions page. |
| app/pages/Instructions.vue | Introduced a new instructions page with details on joining and contact methods. |
| app/components/DC.vue | Added a new component for rendering a Discord profile link based on a given userId. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.