Moved tag selector to a component #543
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
==========================================
+ Coverage 26.69% 27.27% +0.58%
==========================================
Files 189 189
Lines 3136 3120 -16
Branches 456 453 -3
==========================================
+ Hits 837 851 +14
+ Misses 1949 1923 -26
+ Partials 350 346 -4
Continue to review full report at Codecov.
|
OSPFNeighbour
force-pushed
the
tdykes.refactor_tags_to_modal
branch
from
b5a2294 to
25c1920
Compare
sdunster
approved these changes
Jul 24, 2018
| <CheckBox | ||
| style={{ flex: 1, padding: 10 }} | ||
| rightText={option.name} | ||
| onClick={() => this.props.onSelect(option)} |
Member
There was a problem hiding this comment.
if this was it's own component you wouldn't need the closure
| round | ||
| showLoading={this.props.isLoading} | ||
| containerStyle={styles.searchbar} | ||
| onChangeText={text => this.props.onSearch(text)} |
Member
There was a problem hiding this comment.
onChangeText={this.props.onSearch}
| visible={this.state.tagsModal} | ||
| closeModal={this.handleTagBack} | ||
| onSearch={text => this.searchTagOnPress(text)} | ||
| onSelect={option => this.handleTagChange(option)} |
Member
There was a problem hiding this comment.
onSearch, onSelect and backModal can all drop the closure like this:
onSelect={this.handleTagChange}
Contributor
Author
There was a problem hiding this comment.
well thats cool. TIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved tag selector from groups page into a component.