Server - Allow toggle of the DEFAULT user via an ENV variable. #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if ALLOW_ANON exists the DEFAULT USER will be used, else reject the connection
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
==========================================
- Coverage 27.8% 27.78% -0.02%
==========================================
Files 180 180
Lines 2924 2926 +2
Branches 425 426 +1
==========================================
Hits 813 813
- Misses 1789 1790 +1
- Partials 322 323 +1
Continue to review full report at Codecov.
|
sdunster
approved these changes
Jun 26, 2018
| }, | ||
| })).catch(() => Promise.reject(Error('Unauthorised'))), | ||
| )); | ||
| })).catch(() => false), |
Member
There was a problem hiding this comment.
please explain what this changes functionally
| postJWTAuth(!err ? { id: decoded.id, device: decoded.device } : { id: null, device: null }) | ||
| .then(({ user, device }) => ({ user, device })) | ||
| .catch(() => Promise.error('Unauthorised')), | ||
| .catch(() => Promise.reject(Error('Unauthorised')), |
Contributor
Author
There was a problem hiding this comment.
Noticed that one did you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if ALLOW_ANON exists the DEFAULT USER will be used, else reject the
connection